Brakeman and Jenkins: The Duo Detects Defects in Ruby on Rails Code
Ruby code review
-
Upload
jonatas-paganini -
Category
Software
-
view
493 -
download
0
Transcript of Ruby code review
ruby code REVIEW
@jonatasdp
current status
blessed :ship:
Developer || Reviewer
Scenario: developer
your work mattersby Kent Beck
meet std-lib
meet std-lib
meet your js framework
meet your web framework
hmm.
knowledge << feedback
learn details
learn even details
feedback matters
feedback matters
feedback = work together
feedback matters
meet your code base
meet your codebase
benchmark EVERYTHING
review before review
review before review
e esse binding.pry aqui?¬¬
git commit --verbose
gitk
look all PR’s you can!!!
learn from other people
baby steps
avoid same mistake twice
beautiful syntax is basic
will it work?
happy paths are so HAPPY
happy paths are so happy
benchmark your doubts
is the best fit for now?
can I indent your code?
name everything
name your regexes
hack your code
rebase histories in commits
git rebase --interactive
help your reviewer mind
As a developer:provide context enough
Scenario: reviewer
your work mattersby Kent Beck
ask if you don’t know
ask. don’t tell.
test/comprove your theory
benchmark things you discover
write beautiful markdown
explain your job on commits
wikify the best knowledge
As a reviewer:“do not believe in perfect Pull Requests”
by @joaohornburg