Effective Code Review (Or How To Alienate Your Coworkers)
-
Upload
perforce -
Category
Technology
-
view
1.455 -
download
1
description
Transcript of Effective Code Review (Or How To Alienate Your Coworkers)
![Page 1: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/1.jpg)
#
Effective Code Review (Or How To Alienate Your Coworkers)
Geoff NicolSecurity Architect
Stewart LordPrincipal Architect
![Page 2: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/2.jpg)
#
Geoff NicolPerforce Software
Stewart LordPerforce Software
![Page 3: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/3.jpg)
#
1. Why do Code Review?2. Our Philosophy3. The 3 Key Steps4. Bonus Round!5. Questions
Overview
![Page 4: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/4.jpg)
#
Why Do Code Review?
![Page 5: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/5.jpg)
#
• Bugs happen• Hard to fix when shipped• Builds a stronger team• Bottom line: cheap, good and fast!
Why Do Code Review?
![Page 6: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/6.jpg)
#
• JPL estimates $25,000 saved per inspection• 55-60% defect detection rate• 14% more productivity, 90% fewer defects
Source: Code Complete by Steve McConnell
Why Do Code Review?
![Page 7: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/7.jpg)
#
Our Philosophy
![Page 8: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/8.jpg)
#
"Optimize user happiness to lines of code ratio"- Thomas Fuchs
• Quality before commit• Best UX possible• Learn from each other
Philosophy
![Page 9: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/9.jpg)
#
The 3 Key Steps
![Page 10: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/10.jpg)
#
1. Step away from the code2. Don’t look at the code3. Stare deeply into the code
The 3 Key Steps
![Page 11: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/11.jpg)
#
• Do we know enough?• Is it too big?• Side effects?• Roadmap?• Release cycle?
1. Step Away
![Page 12: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/12.jpg)
#
• Start with UX• Can UX be simplified?• Does it look good?• Look at API• Look at the context
2. Don’t Look
![Page 13: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/13.jpg)
#
• Inspect line by line• Simplify, simplify, simplify• Consider edge cases• Put your evil hat on
3. Stare Deeply (Logic)
![Page 14: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/14.jpg)
#
• Balance for readability• Ensure code is well commented• Would a var by any other name smell as sweet?
3. Stare Deeply (Finesse)
![Page 15: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/15.jpg)
#
Bonus Round!
![Page 16: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/16.jpg)
#
• Ensure code has tests• Integrate tests with reviews• Integrate staging with reviews• Pair programming• Look at contributor guidelines
Much Bonus, So Round!
![Page 17: Effective Code Review (Or How To Alienate Your Coworkers)](https://reader033.fdocuments.in/reader033/viewer/2022061201/5469b9c9af7959ff128b45e9/html5/thumbnails/17.jpg)
#
• Check your ego• Ask why• Iterate• Try try again• GIFs, Emojis, Memes, Youtube
With Coworkers Like These…