Effective Code Review

Post on 31-Dec-2015

30 views 0 download

Tags:

description

Effective Code Review. Dan Menard. Hi. My name is Dan. I work at Netflix (TV UI Engineer). I ’ m Canadian, but I live in California. I ’ m galeophobic. …and I ’ m here to talk about code review. Everyone should do code review. The Benefits of Code Review. - PowerPoint PPT Presentation

Transcript of Effective Code Review

Effective Code ReviewDan Menard

Hi. My name is Dan. I work at Netflix (TV UI Engineer).

I’m Canadian, but I live in California.

I’m galeophobic.

…and I’m here to talk about code review.

Everyone should do code review.

The Benefits of Code Review You write better code when you know it will be reviewed.

A second (or third, or fourth…) set of eyes will help spot defects.

More than one person understands your code.

It’s a great way to learn more about the codebase.

It will make you a better developer.

What to look (out) for. Bad Design.

Lack of clarity.

Lack of conformity.

Performance hazards.

What’s not important? Optimization.

Skill and experience gaps.

Personal style.

Fitting code review into your dev cycle. When should you review code?

What level of persistence do you need?

Should you use a code review tool?

Code review for geographically dispersed teams. Helps manage asynchronous coding.

Builds a more cohesive codebase.

Gives you a real status update.

Builds trust and morale.

How to sell code review to others. Not as hard as selling unit tests.

Bottom-up approach.

Just do it.

Code review is for everyone. Small companies, medium-sized companies, large companies.

Open source and closed source.

Pros or amateurs.

Local or remote.

Solo projects are no exception.

www.dan-menard.com

daniel.menard@gmail.com

@dan_menard